SamplingTransactionProfilerFactory.Dispose disposes the Task, not the SampleProfilerSession (resource leak) - #5480
Closed
tsushanth wants to merge 1 commit into
Conversation
…t the SampleProfilerSession (resource leak)
Collaborator
|
@tsushanth I think this is a duplicate of: #5470 also includes some other changes that make this fix reachable, so I'll close this PR. Worth noting that this fix is mostly cosmetic - this 'leak' only ever happens when shutting down the Sentry SDK (typically when finishing the process) so, in practice, will impact almost nobody. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Dispose() to call task.Result.Dispose() on the SampleProfilerSession instead of disposing the Task itself
Found via automated repo scanning, fix written and reviewed before opening.